Avoid events boomeranging from frontend #7093
Conversation
|
Will this solve issue with ChatInterface? I.e. the problem that if you don't type slowly then text will disappear? chatinterface-text-disappearing.mp4 |
I have never encountered that problem, the problem it is meant to solve is that the chat feed scroll position isn't stable. |
|
I will make a separate issue then. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7093 +/- ##
==========================================
- Coverage 82.22% 81.74% -0.49%
==========================================
Files 326 326
Lines 48548 48586 +38
==========================================
- Hits 39920 39717 -203
- Misses 8628 8869 +241 ☔ View full report in Codecov by Sentry. |
|
A reproducer would be very helpful. I definitely can't reproduce this with a bare chat interface. |
|
Hmmm. The problem is only with the deployed app. When developing on jupyter hub with proxy server there is no problem. That is strange as it should be the same. But I also experience my deployed apps being slower even though they have the same resources available. I've had the problem "for ever". Thought everyone was experiencing it. |
|
Yeah literally never seen it and we have many chat apps in production with different clients. |
philippjfr
force-pushed
the
boomerang_fix
branch
from
ce5eecd to
830131e
Compare
|
Hey @philippjfr any idea when this will be available? (I know 1.4.5, just wondering if there is a release date for that, or an option to release it sooner?) Thanks! |
|
We are observing the same issue as @MarcSkovMadsen in #7096 |
|
I was planning to cut 1.5.0rc1 today and then make the proper release some time next week. |
|
Awesome - appreciate it. 👍🏻 |
This adds a long overdue change which ensures that events arriving from the frontend do not boomerang. There was a previous attempt at doing this but instead of skipping events being applied that originated on the frontend it cancelled the processing of new events after a property change was made. These approaches have potentially similar effects but in fact are quite different, since the old change effectively would potentially cause a property to revert to an older value.
Fixes #7096
Fixes #6738
Fixes #6414